Marc Contributors #2605
Merged
Marc Contributors #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…co/pipeline/transformer/marc_common/transformers/MarcElectronicResourcesTest.scala Co-authored-by: Robert Kenny <[email protected]>
* implement common MARC description * use comon description in Sierra * use common description in XML
kenoir
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Part of #2563
This moves the Contributor transformation into marc_common
Have we considered potential risks?
This is quite a big change. The existing Sierra Contributors transformer has accreted quirks over time and I think it was worth splitting it apart like this to be a bit more SRP.
There is a little bit of possibly Sierra-specific behaviour in here, (x00 $t means Agent) but I don't believe that is correct behaviour anyway, so it should probably be removed at some point. It also does not appear in any of the EBSCO sample, so It is therefore not worth going to the effort of creating a separate source-specific specialisation to cover this quirk.