Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read license information from licenseNote in premis access condition #2695

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Aug 30, 2024

What does this change?

This PR updates how license information can be derived from METS where the PREMIS element is used to provide access conditions.

Currently where the rightsBasis is "License" we ignore the licenseNote field when parsing METS that contains the PREMIS element (i.e. Works sourced from Archivematica AKA anything "Born Digital"). This change addresses that problem to ensure the correct license information is available on Works.

See this Slack thread: https://wellcome.slack.com/archives/C02ANCYL90E/p1724408305952489

Addresses wellcomecollection/wellcomecollection.org#11016

Note

This change is currently deployed manually to a dev tag here. Ensure it is returned to the correct tag after release.

How to test

  • Run the tests, do they pass?
  • Deploy a dev METS transformer image into the pipeline and reindex some works with METS that match the license pattern this addresses (qd84awx8). Do they get the expected license?

Here is an example of a work with the CC-BY-NC license added by this process.

When the born digital toggle is turned on, this is what it looks like in the front-end:
Screenshot 2024-09-02 at 11 41 22

How can we measure success?

Born Digital items have the correct license information and can be made available to the public for viewing.

Have we considered potential risks?

This change updates how we read existing licenses, referring to the rightsBasis for which field to read, this opens the possibility existing correctly licensed works will be changed. This risk is mitigated by falling back to existing behaviour and spot checking METS to see that the behaviour will remain as expected.

@kenoir kenoir requested a review from a team August 30, 2024 14:52
Copy link
Contributor

@StepanBrychta StepanBrychta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kenoir kenoir force-pushed the rk/read-license-note-from-mets-premis branch from 729c1c5 to a8218a3 Compare September 3, 2024 15:23
@kenoir kenoir merged commit 30ecdac into main Sep 4, 2024
5 checks passed
@kenoir kenoir deleted the rk/read-license-note-from-mets-premis branch September 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants