Remove DLQ alarms from pipeline services #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we missing a commit here to bump the sqs tf module version? |
StepanBrychta
force-pushed
the
Remove-DLQ-alarms-from-pipeline-services
branch
from
8adc78a to
acd9a46
Compare
|
@kenoir Yes, fixed! |
kenoir
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
wellcomecollection/platform#5777
This removes DLQ alarm for all 16 catalogue pipeline services. This change depends on wellcomecollection/terraform-aws-sqs#11
How to test
Once this PR is merged and the new version of the module is released, the result of running
terraform planfrom thecatalogue-pipeline/pipeline/terraform/2024-08-15folder should include the removal of 16 DLQ alarm resources, one for each pipeline service.How can we measure success?
All catalogue pipeline DLQ alarms are removed, no other resources are affected.
Have we considered potential risks?