Generalise lambda functionality into module #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenoir
force-pushed
the
rk/lambda-common
branch
from
8a2f52c to
155a242
Compare
paul-butcher
approved these changes
Jan 3, 2025
common/lambda/src/test/scala/weco/lambda/ConfigurationTest.scala
Outdated
Show resolved
Hide resolved
5 tasks
kenoir
force-pushed
the
rk/lambda-common
branch
from
6fa1b8d to
f88c3ef
Compare
kenoir
force-pushed
the
rk/lambda-common
branch
from
1127e13 to
ac0edb4
Compare
kenoir
force-pushed
the
rk/lambda-common
branch
from
632cb27 to
d773ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change moves the lambda common classes to a weco.lambda module and adopts use in the relation_embedder and batcher, in order to generalise functionality around lambdas and prepare for further services to convert.
How to test
How can we measure success?
Quicker movement to lambdas from ECS services in the future.
Have we considered potential risks?
These should be a functional no-op, so the risk is minimised.