Remove unused js #2803
Merged
Remove unused js #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This removes the Javascript and CSS linting stuff from the root of the project.
There is only one small part of this project where Javascript is used, and that is rarely touched and likely to be removed as its use has been superseded by the datalink explorer
The now-deleted package.json was a source of some critical vulnerability warnings (https://github.com/wellcomecollection/catalogue-pipeline/security/dependabot/220 and https://github.com/wellcomecollection/catalogue-pipeline/security/dependabot/211). Although these are not real vulnerabilities because this package was unused, and certainly not on a live system, they are a distraction when we investigate actual vulnerabilities.
How to test
Deleted code is debugged code!
How can we measure success?
Fewer critical vulnerabilities, fewer dependencies to keep up to date.
Have we considered potential risks?
Maybe someone is using the eslint pre commit hook, and I've misjudged its usefulness in this repository. If so, we can close this PR unmarked and I'll work on sorting out those transitive dependencies.