Not necessary to output to /dev/tty, is forbidden in lambda env #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
For wellcomecollection/platform#5870
A tweak to ensure secret retrieval is logged correctly in the bash secrets lambda extensions.
This error appears in logs in a deployed lambda. I believe this is because /dev/tty is unavailable in the lambda environment, although the command to retrieve the secret is succeeding.
How to test
How can we measure success?
Less confusing errors, better logs.
Have we considered potential risks?
The 2024-11-18 pipeline is not the production pipeline yet, so a failure should not impact end users.