Unwrap function call in bash secrets script #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenoir
force-pushed
the
rk/unwrap-function-call
branch
from
df60259 to
6ac1d00
Compare
paul-butcher
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
For wellcomecollection/platform#5870
This change "unwraps" the call to extract the secret from secrets manager. For some reason this was causing the secret retrieval to fail when run in a lambda environment.
I've tested this in AWS and this change causes the initialisation to suceed.
How to test
The "relation_embedder" custom event was created by dumping the json encoded output of the
post_to_rie.pyscript to stdout and saving that in the AWS Lambda console.How can we measure success?
Lambda deploys and runs successfully.
Have we considered potential risks?
The 2024-11-18 pipeline is not in production use, the risk is minimised.