Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events endpoint documentation #40

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Add events endpoint documentation #40

merged 4 commits into from
Nov 18, 2024

Conversation

rcantin-w
Copy link
Contributor

@rcantin-w rcantin-w commented Nov 15, 2024

What does this change?

wellcomecollection/content-api#124

Long overdue documentation for the events endpoints!
I also added uid to articles' since we added it in recently.

I did my best in my first go at using this language/tool, so let me know if you spot anything!

Note

This repo always makes changes in its PRs to change the internal links to match the branch. But I've personally only touched reference/content.yml, so ignore the other files.

How to test

You can run this locally with yarn start, and consult the new docs!

How can we measure success?

It's up to date and useful for anyone we might onboard.

Have we considered potential risks?

N/A

@rcantin-w rcantin-w marked this pull request as ready for review November 15, 2024 14:20
@rcantin-w rcantin-w requested review from a team as code owners November 15, 2024 14:20
@@ -1,6 +1,6 @@
# 1. Exploring Wellcome Collection's APIs

[View on GitHub](https://github.com/wellcomecollection/developers.wellcomecollection.org/blob/main/notebooks/01-exploring-wellcome-collections-apis.ipynb) | [Run in Google Colab](https://colab.research.google.com/github/wellcomecollection/developers.wellcomecollection.org/blob/main/notebooks/01-exploring-wellcome-collections-apis.ipynb)
[View on GitHub](https://github.com/wellcomecollection/developers.wellcomecollection.org/blob/add-events/notebooks/01-exploring-wellcome-collections-apis.ipynb) | [Run in Google Colab](https://colab.research.google.com/github/wellcomecollection/developers.wellcomecollection.org/blob/add-events/notebooks/01-exploring-wellcome-collections-apis.ipynb)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why these have all been changed from main to add-events?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo always makes changes in its PRs to change the internal links to match the branch, so you can navigate within it. They change it back when you merge. I haven't touched those files!

Copy link

@davidpmccormick davidpmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the docs, but yaml makes sense to me

@rcantin-w rcantin-w merged commit 82de0c0 into main Nov 18, 2024
2 checks passed
@rcantin-w rcantin-w deleted the add-events branch November 18, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants