Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style: fix home banner layout for short intro #438

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Nov 27, 2024

Summary

Improves home banner balance when displaying shorter intro texts.

Before, setting a brief intro text would center the container and enlarge the image.

Screenshots

Before:

b

After:

a

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the bug Something isn't working label Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 30b1df5
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/674732ad40d56e0008527d56
😎 Deploy Preview https://deploy-preview-438--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit 9e58b3a into main Nov 27, 2024
6 of 7 checks passed
@welpo welpo deleted the ¡style/home-banner-short-intro branch November 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant