-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(shortcodes): add 'aside' shortcode for side notes #452
Conversation
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello. I tried to use new
So I tried this:
and this:
but none of them works. [1] from documentation: https://welpo.github.io/tabi/blog/shortcodes/#aside-side-margin-note [2] from |
Try
|
Just updated the docs (da1b6bb) to make it clearer! Thanks~ |
It works, thanks! |
I've noticed another things. Take a look into attached screenshot. If I use If I put f I put What should I check? |
This is all in one page/article? Can you give me the page content (markdown with shortcode calls) so I can test the exact same setup on my end? |
Yes, one page.
Of course. Please check your e-mail box. |
Got it! Make sure you call the shortcode on its own line, not inside a paragraph. That should fix it! I've added a warning to the docs (1dcd615) |
Thank you for checking this. |
Thank you for helping improve tabi! |
Summary
Adds
aside
shortcode for supplementary content.Users can set the margin on which to show the note. The content can be provided as a
text
parameter or using body within the shortcode tags (see docs).Related issue
Resolves #444
Changes
Accessibility
Uses semantic HTML (
<aside>
) and has good contrast for the mobile look.Screenshots
Wide screen:
Mobile (or narrow screen):
Type of change
Checklist
theme.toml
with a sane default for the featureconfig.toml
in tabi-startconfig.toml
commentstheme.toml
comments