Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HTMLOrSVGElement mixin #5247

Closed
wants to merge 1 commit into from

Conversation

bkardell
Copy link
Contributor

Renames relatively recent HTMLOrSVGElement IDL mixin to HTMLOrForeignElement in order to reflect its wider use in MathML as well, which previously was just Element. This is referenced in the new interface defined in MathML-Core and aimed at resolving this historical oddity.

(See WHATWG Working Mode: Changes for more details.)

@domenic
Copy link
Member

domenic commented Jan 31, 2020

This seems to modify a review draft, and the commit message is an attempt to publish a new review draft? Please modify source instead.

@bkardell
Copy link
Contributor Author

Lol, oh noes... I was so caught up in it I missed this somehow.. ok, let me close and resubmit the right thing this time. Apologies.

@bkardell bkardell closed this Jan 31, 2020
@domenic
Copy link
Member

domenic commented Jan 31, 2020

For future reference, you can also just push commits to the same branch, and it'll stay part of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants