Skip to content

Commit

Permalink
Isolate windows
Browse files Browse the repository at this point in the history
  • Loading branch information
@whikloj
whikloj committed Jun 24, 2022
1 parent bf80bff commit c270de7
Showing 1 changed file with 13 additions and 10 deletions.
23 changes: 13 additions & 10 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ jobs:
strategy:
fail-fast: false
matrix:
php-versions: ["7.4", "8.0"]
experimental: [false]
host-os: ["ubuntu-latest"]
#php-versions: ["7.4", "8.0"]
#experimental: [false]
#host-os: ["ubuntu-latest"]
include:
- php-versions: "7.3"
experimental: false
host-os: "ubuntu-18.04"
- php-versions: "8.1"
experimental: true
host-os: "ubuntu-latest"
# - php-versions: "7.3"
# experimental: false
# host-os: "ubuntu-18.04"
# - php-versions: "8.1"
# experimental: true
# host-os: "ubuntu-latest"
- php-versions: "8.1"
experimental: true
host-os: "windows-latest"

This comment has been minimized.

Sign in to view

Copy link
@jonasraoni

jonasraoni Jun 24, 2022

Contributor

@whikloj FYI, the "Fetch" test was timing out in my Windows box, I didn't check what was happening (lack of time) :)

This comment has been minimized.

Sign in to view

Copy link
@whikloj

whikloj Jun 24, 2022

Author Owner

Unfortunately the mockwebserver I am using for the FetchTest does not support Windows and there doesn't seem to be much traction for it.

This comment has been minimized.

Sign in to view

Copy link
@whikloj

whikloj Jun 24, 2022

Author Owner

Which leads to me to a problem, I (as a non-Windows developer) can't support Windows without a working CI setup. So if you know of mock webserver that works on PHP in Windows or if you have any cycles to spare with this effort donatj/mock-webserver#15 I would be very grateful.

This comment has been minimized.

Sign in to view

Copy link
@jonasraoni

jonasraoni Jun 24, 2022

Contributor

As this package is being used only by the tests at FetchTest.php, I think I can take a look 😁

This comment has been minimized.

Sign in to view

Copy link
@whikloj

whikloj Jun 25, 2022

Author Owner

I'm going to kick out a 4.1.1 release for you, and if you can either a) help get mock-webserver to work under Windows or b) suggest a better way to mock web requests then I can try to keep the Windows support up. I tried php-vcr (see #32) but it couldn't cover my needs.

This comment has been minimized.

Sign in to view

Copy link
@whikloj

whikloj Jun 25, 2022

Author Owner

Actually it will be 4.2.0 as there are new features included 🤦

This comment has been minimized.

Sign in to view

Copy link
@jonasraoni

jonasraoni Jun 25, 2022

Contributor

Thanks, I'm trying to clear my pile of tasks, and now there's one less :)
I'll take a look within this week.
Expand Down Expand Up @@ -55,8 +55,11 @@ jobs:
- name: Install dependencies
run: composer install --prefer-dist --no-progress

- name: Check codestyle
run: composer check

- name: Run test suite
run: composer test
run: composer phpunit

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
Expand Down

0 comments on commit c270de7

Please sign in to comment.