Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/picker custom top element #3465

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Feat/picker custom top element #3465

wants to merge 8 commits into from
+55 −2

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented Dec 23, 2024 •
edited
Loading

Description

Picker new customTopElement, onItemSelection props.
onItemSelection get's called when item selection toggled, and can indicate about the draft value of the multi picker.
customTopElement will be render above the PickerItemList.

Changelog

Picker support for new customTopElement and onItemSelection callback function.

Additional info

MADS-4575

@adids1221 adids1221 requested a review from M-i-k-e-l December 23, 2024 08:34
M-i-k-e-l
M-i-k-e-l reviewed Jan 2, 2025
View reviewed changes
demo/src/screens/componentScreens/PickerScreen.tsx Outdated Show resolved Hide resolved
src/components/picker/PickerItemsList.tsx Outdated Show resolved Hide resolved
src/components/picker/PickerItemsList.tsx Outdated Show resolved Hide resolved
src/components/picker/types.ts Outdated Show resolved Hide resolved
src/components/picker/PickerItemsList.tsx Outdated Show resolved Hide resolved
src/components/picker/types.ts Outdated Show resolved Hide resolved
@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l Jan 2, 2025
@adids1221 adids1221 requested a review from M-i-k-e-l January 9, 2025 08:26
@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 Jan 9, 2025
M-i-k-e-l
M-i-k-e-l reviewed Jan 13, 2025
View reviewed changes
src/components/picker/types.ts Outdated Show resolved Hide resolved
src/components/picker/types.ts Outdated Show resolved Hide resolved
src/components/picker/index.tsx Outdated Show resolved Hide resolved
src/components/picker/PickerItemsList.tsx Outdated Show resolved Hide resolved
@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l Jan 13, 2025
@adids1221 adids1221 requested a review from M-i-k-e-l January 13, 2025 09:49
@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 Jan 13, 2025
M-i-k-e-l
M-i-k-e-l approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@M-i-k-e-l M-i-k-e-l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add renderCustomTopElement to the API
Also fix the PR's description (it only adds renderCustomTopElement, name change etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adids1221 @M-i-k-e-l