Product Selector - Reset filters after completing selection or dismissal

[selanthiraiyan]

Closes: #14624

Description

When you apply filters in the product selector screen the main product list screen is affected as the applied core data predicate changes are received by the main product list screen as well.

To avoid the above issue, this PR starts resetting the filters once the product selection process is complete using the saved product settings.

Steps to reproduce

Prerequisites

• Use a Woo store with more than 100 products.
• You can create a JN store and generate 100+ products using Woo Smooth generator.
• Using the smooth generator helps to generate products with different types, status and category. (Helps with testing filters)

Products list

1. Login into the app if needed
2. Navigate to Products tab
3. Tap "Filter"
4. Apply any filter and ensure that products are filtered correctly.
5. Navigate to the Orders tab
6. Tap "+" -> "Add products"
7. Tap "Filter"
8. Apply a filter that is different from the main product list screen.
9. Ensure that products are filtered correctly.
10. Select a product and create an order.
11. Navigate back to the Products tab and ensure that the product list and filters are correct. (They shouldn't be impacted by the filters applied in the product selector screen.)
12. Repeat steps from 5 to 9
13. Dismiss the product selector screen without selecting a product.
14. Navigate back to the Products tab and ensure that the product list and filters are correct. (They shouldn't be impacted by the filters applied in the product selector screen.)

Testing information

• Tested that filters applied in product selector don't impact product list screen.
• Tested that filtering works as expected in product list and product selector screens.

Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-25.at.10.34.28.mp4

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14764-5220e95
	Version	21.3
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	5220e95
	App Center Build	WooCommerce - Prototype Builds #12291

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[itsmeichigo]

Thank you for the fix! When testing I found that the product selector can be dragged to dismiss, in which case the filter is not updated. We should handle that case also:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-25.at.15.11.57.mp4

[selanthiraiyan]

When testing I found that the product selector can be dragged to dismiss, in which case the filter is not updated. We should handle that case also:

Thanks for reporting this, @itsmeichigo!

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-25.at.18.25.57.mp4

On a simulator running iOS 17.4, I cannot swipe and dismiss the product selector. Also, I see that the interactiveDismissDisabled is used here.

Could you please share in which simulator version you tested this?

[itsmeichigo]

On a simulator running iOS 17.4, I cannot swipe and dismiss the product selector. Also, I see that the interactiveDismissDisabled is used here.
Could you please share in which simulator version you tested this?

Interesting! I can confirm that I cannot dismiss the product selector on 17.4 either but can dismiss on both 18.1 and 18.2. This seems to be an issue with iOS 18.

[itsmeichigo]

What do you think about resetting the filter on the product list upon viewWillAppear? That would also help with the issues regarding using the storage for dashboard cards.

[selanthiraiyan]

Interesting! I can confirm that I cannot dismiss the product selector on 17.4 either but can dismiss on both 18.1 and 18.2. This seems to be an issue with iOS 18.

Good find. Thanks for sharing, @itsmeichigo!

What do you think about resetting the filter on the product list upon viewWillAppear? That would also help with the issues regarding using the storage for dashboard cards.

I tried this option initially and decided not to go this way. I want to avoid reloading the screen from viewWillAppear to avoid changing the table view scroll position.

I think we can merge this PR, considering this is an iOS issue. What do you think?

[itsmeichigo]

I tried this option initially and decided not to go this way. I want to avoid reloading the screen from viewWillAppear to avoid changing the table view scroll position.

Did you see the table changing position when you tried the solution? I did a quick check as well and didn't see it, but I may have missed something.

If we can confirm the above, I suppose it's alright to merge the PR.