WIP - Move all WordPressAuthenticator sources into this repo #14779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
mokagio
force-pushed
the
mokagio/fold-wordpress-authenticator
branch
2 times, most recently
from
ef7a776 to
c4e4f34
Compare
|
|
mokagio
force-pushed
the
mokagio/fold-wordpress-authenticator
branch
3 times, most recently
from
88a55cf to
662b543
Compare
This was referenced Jan 3, 2025
It got turned on by the 16.2 update and resulted in build failures.
When wordpress-mobile/WordPressAuthenticator-iOS#867 was merged, I had already started working on folding WordPressAuthenticator and didn't sync with the team about it. This commit picks all the changes from that PR and copies them in one go into the local version of the WordPressAuthenticator codebase.
It turned out that every project made a copy of that file, which defeated the whole purpose. Apparently, we cannot have files shared at the workspace level. It might still be possible to achieve the same result in the future, but that would require every project being set up with base configuration files and referencing the shared file from there, without adding the shared file itself to the projects. But to do that, we'll need each project set up that way, which is out of scope for the work I'm currently doing of folding the WordPressAuthenticator and WordPressKit libraries into WooCommerce iOS.
16.0 is the same as WooCommerce iOS uses
mokagio
force-pushed
the
mokagio/fold-wordpress-authenticator
branch
from
f161a2d to
ca60ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14329
Closes: #
Description
Steps to reproduce
Testing information
Screenshots
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: