[Woo POS] Improve next page trigger #14827
Draft
+81
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we tracked the scroll position and compared it to a threshold based on view height. This resulted in loading the next page whenever the view is scrolled. This changes the approach to show the loading cell whenever we get to the bottom of the list, as long as there are still pages to load. When the loading cell appears, which with the move to LazyVStack is only when it’s scrolled in to view, we start the next page fetch request.
This avoids us calling `loadNextItems` for the root list when a child list is scrolled to the bottom. It also lays the groundwork for calling the correct next item function when we add pagination support.
Generated by 🚫 Danger |
|
|
Base automatically changed from
feat/14702-replace-POSParentProduct-with-POSVariableParentProduct
to
trunk
January 9, 2025 00:48
5 tasks
jaclync
approved these changes
Jan 10, 2025
I will comment about my thoughts on the infinite scroll separately in | case parent(POSItem) | ||
| } | ||
|
|
||
| @Environment(\.floatingControlAreaSize) var floatingControlAreaSize: CGSize |
There was a problem hiding this comment.
nit: this could be private?
Suggested change
| @Environment(\.floatingControlAreaSize) var floatingControlAreaSize: CGSize | |
| @Environment(\.floatingControlAreaSize) private var floatingControlAreaSize: CGSize |
Comment on lines
+39
to
+40
| guard case .root = node else { return } | ||
| Task { await posModel.loadNextItems() } |
There was a problem hiding this comment.
I'm guessing this is where we'll trigger the child item next page load as well. Do you plan to add a different loadNextItems given a parent node, or add a parameter to loadNextItems with the parent item?
| itemStates: [:])) | ||
| } else { | ||
| let itemStates = itemsViewState.itemsStack.itemStates | ||
| .filter { allItems.contains($0.key) } | ||
| itemsViewState = .init(containerState: .content, | ||
| itemsStack: ItemsStackState(root: .loaded(allItems), | ||
| itemsStack: ItemsStackState(root: .loaded(allItems, hasMoreItems: pagedItems.hasMorePages), |
There was a problem hiding this comment.
Maybe can have a test case for this when pagedItems.hasMorePages is true, if not already? Asking because I was seeing all hasMoreItems: false in the PointOfSaleItemsControllerTests diffs.
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #14696
Merge after: #14818
Description
This PR simplifies and improves the trigger for
loadNextPageon POS item lists. This is preliminary work before adding pagination support for variation lists. The root and child lists also now use the sameItemListcomponent, which contains everything it needs to show the scrollview and its content.Previously we tracked the scroll position and compared it to a threshold based on view height. This resulted in loading the next page whenever the view is scrolled.
Now we show the loading cell whenever we get to the bottom of the list, as long as there are still pages to load.
When the loading cell appears, we start the next page fetch request.
Steps to reproduce
Set the page size for
ProductsRemote.loadProductsForPointOfSaleto something small enough that you can see multiple pages loading, but large enough that the page more than fills the screen. I use 10.Open the POS and check that you can load multiple pages.
Observe network requests and check that we don't make any extra requests.
Breakpoint in
loadNextItemsto see that it's only called when expected.Check that the new page is _only_loaded when the bottom of the list content is scrolled in to view.
Check that variation lists don't trigger any requests. This is preparatory work for variation pagination support.
Testing information
N.B. If you test this with a very small page size, it won't work, because the loading cell doesn't disappear and reappear between load events, but for realistic page sizes (10+) it works well.
This fixes a bug where scrolling any amount on the list, even if it's not at the end, would result in a next page load.
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: