Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HACK Week: Support filter history in product list #14831

Open
wants to merge 7 commits into
base: hackweek/yosemite-product-filter-history
Choose a base branch
from

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 9, 2025

Part of #14791

Description

This PR enables saving, applying, removing and resetting filter history in the product list.

Steps to reproduce

  • Ensure that filterHistoryOnOrderAndProductLists feature flag is enabled and run the app.
  • Log in to a store with existing products.
  • Navigate to the Products tab > Filters > select the Clock button on the top right.
  • Confirm that the filter history is empty by default.
  • Navigate back to the Filters screen, select some filters and apply it.
  • Navigate back to the Filter history screen and confirm that the last filter is displayed in the history.
  • Go back to the Filters screen and apply new filters.
  • Go to the Filter history screen and confirm that the latest filters are displayed at the top of the history.
  • Swipe left on one of the filters and tap Delete. Confirm that the filter is no longer displayed on the Filter History screen
  • Apply a past filter and confirm that the Filters screen are updated with the details of the filter.
  • Tap Show Products and confirm that the order list are updated correctly.

Testing information

Tested on simulator iPhone 16 Pro iOS 18.2 in light mode, dark mode and different text sizes and confirmed that all look good and work as expected.

Screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-09.at.13.59.24.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: enhancement A request for an enhancement. feature: product list Related to the product list. labels Jan 9, 2025
@itsmeichigo itsmeichigo added this to the 21.4 milestone Jan 9, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 9, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14831-dcd22b9
Version21.3
Bundle IDcom.automattic.alpha.woocommerce
Commitdcd22b9
App Center BuildWooCommerce - Prototype Builds #12437
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review January 9, 2025 08:38
@wpmobilebot wpmobilebot modified the milestones: 21.4, 21.5 Jan 10, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.4 has now entered code-freeze, so the milestone of this PR has been updated to 21.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product list Related to the product list. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants