Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revamp Shipping Labels - Customs] Items warning details #14836

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Jan 9, 2025

Closes: #13784

Description

With this PR we close the Customs UI task with these additions into the customs items box:

  • Empty red boxes in the collapsed state to warn about the required missing data
  • Add warning text for required missing data.
  • Add warning text for invalid hs tariff number.
  • Remove the exclamation mark in the collapsed state when all the required information is available.
  • Adding the right keyboard for each case

Note: The currency formatting is coming in a future PR

Steps to reproduce

  1. Go to orders
  2. Tap on a complete order which can render a shipping label
  3. Tap on Create Shipping Label
  4. Tap on the Customs pencil button
  5. Expand the dummy product detail row
  6. Check that a warning text is added when the required fields (Description, Value, Weight) are empty.
  7. Check that the HS Tariff also shows a warning text when it's not valid
  8. When the box is collapsed, check that we show an empty red box for the missing values

Testing information

N/A

Screenshots

Simulator.Screen.Recording.-.iPhone.16.-.2025-01-09.at.11.46.07.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@toupper toupper added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jan 9, 2025
@toupper toupper added this to the 21.4 milestone Jan 9, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 9, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14836-29e156f
Version21.3
Bundle IDcom.automattic.alpha.woocommerce
Commit29e156f
App Center BuildWooCommerce - Prototype Builds #12442
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

private var viewModel: WooShippingCustomsItemViewModel!

override func setUp() {
viewModel = WooShippingCustomsItemViewModel(title: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: super.setUp()

@wpmobilebot wpmobilebot modified the milestones: 21.4, 21.5 Jan 10, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.4 has now entered code-freeze, so the milestone of this PR has been updated to 21.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customs UI
3 participants