[Jetpack Setup] Show error screen directly when Woo is not installed #14837
+15
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14806
Description
This PR adds an improvement to the flow post Jetpack setup: when we detect that the site doesn't have Woo, we will show the error screen right away, instead of navigating to the store picker and hoping that the user will figure out the next step themselves. This change also fixes the crash of the linked ticket.
Note
I didn't add any unit tests for this part, adding the tests will require more work than the fix itself as the Coordinator doesn't have any tests yet, but let me know if it's a blocker.
Steps to reproduce
Important
Calypso's plugin installation seems to be broken, it will take you to the login page after finishing the installatio, I plan on investigating this further. For this PR, to be able to test the full flow, apply the following
patch, then when the installation is done just dismiss the WebView.
Testing information
Screenshots
Before (crash)
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-09.at.13.17.35.mp4
Before (without crash)
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-09.at.14.52.27.mp4
After
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-09.at.14.42.14.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: