-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping labels] Add basic UI for editing an origin address #14838
Open
rachelmcr
wants to merge
10
commits into
trunk
Choose a base branch
from
issue/13781-edit-origin-address-ui
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+297
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelmcr
added
the
feature: shipping labels
Related to creating, ordering, or printing shipping labels.
label
Jan 9, 2025
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
rachelmcr
force-pushed
the
issue/13781-edit-origin-address-ui
branch
from
January 9, 2025 18:19
5850be4
to
d8f43fd
Compare
4 tasks
bozidarsevo
reviewed
Jan 9, 2025
Comment on lines
+87
to
+89
if field.required { | ||
Text("*") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #13781
Description
This introduces UI to be used for editing an origin address in the Woo Shipping label flow. It includes:
The following UI elements (and a view model to handle the logic) will be added in a later PR:
Testing information
processing
status.*
by the label) except Company.Screenshots
Screencast:
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-09.at.18.05.58.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: