Skip to content

Commit

Permalink
Merge pull request #21246 from wordpress-mobile/use_dependency_diff_f…
Browse files Browse the repository at this point in the history
…rom_ci_toolkit

Use dependency diff from ci toolkit
  • Loading branch information
wzieba authored Sep 25, 2024
2 parents 4ae91c2 + 2fbc871 commit 17ac224
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 96 deletions.
66 changes: 0 additions & 66 deletions .buildkite/commands/dependency-tree-diff.sh

This file was deleted.

2 changes: 1 addition & 1 deletion .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ steps:
- label: "Dependency Tree Diff"
command: |
cp gradle.properties-example gradle.properties
.buildkite/commands/dependency-tree-diff.sh
comment_with_dependency_diff 'WordPress' 'wordpressVanillaReleaseRuntimeClasspath'
if: build.pull_request.id != null
plugins: [$CI_TOOLKIT]

Expand Down
29 changes: 0 additions & 29 deletions WordPress/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -658,35 +658,6 @@ tasks.register("violationCommentsToGitHub", ViolationCommentsToGitHubTask) {
]
}

tasks.register("dependencyTreeDiffCommentToGitHub", ViolationCommentsToGitHubTask) {
repositoryOwner = "wordpress-mobile"
repositoryName = "WordPress-Android"
pullRequestId = System.properties['GITHUB_PULLREQUESTID']
oAuth2Token = System.properties['GITHUB_OAUTH2TOKEN']
gitHubUrl = "https://api.github.com/"
createCommentWithAllSingleFileComments = true
createSingleFileComments = false
commentOnlyChangedContent = true
commentOnlyChangedFiles = false
minSeverity = SEVERITY.INFO
commentTemplate = """
<details><summary>The PR caused some dependency changes (expand to see details)</summary>
<p>
```diff
{{{violation.message}}}
```
</p>
</details>
*Please review and act accordingly*
"""
violations = [
["GENERIC", ".", ".*/build/.*/diff/.*\\.txt\$", "DependenciesDiffChecker"],
]
}

tasks.register("printVersionName") {
doLast {
println android.defaultConfig.versionName
Expand Down

0 comments on commit 17ac224

Please sign in to comment.