Reverted changes to CampaignListingFragment

wordpress-mobile · Nov 21, 2024 · 212f32b · 212f32b
1 parent 4f5cf90
commit 212f32b
Showing 1 changed file with 7 additions and 18 deletions.
diff --git a/.../org/wordpress/android/ui/blaze/blazecampaigns/campaignlisting/CampaignListingFragment.kt b/.../org/wordpress/android/ui/blaze/blazecampaigns/campaignlisting/CampaignListingFragment.kt
@@ -80,23 +80,8 @@ class CampaignListingFragment : Fragment() {
     }
 
     private val viewModel: CampaignListingViewModel by viewModels()
-    private val campaignViewModel: CampaignViewModel by activityViewModels()
-
-    private var pageSource: CampaignListingPageSource? = null
-
-    override fun onCreate(savedInstanceState: Bundle?) {
-        super.onCreate(savedInstanceState)
-        pageSource = savedInstanceState?.getSerializableCompat(CAMPAIGN_LISTING_PAGE_SOURCE)
-            ?: arguments?.getSerializableCompat(CAMPAIGN_LISTING_PAGE_SOURCE)
-        if (pageSource == null) {
-            pageSource = CampaignListingPageSource.UNKNOWN
-        }
-    }
 
-    override fun onSaveInstanceState(outState: Bundle) {
-        super.onSaveInstanceState(outState)
-        outState.putSerializable(CAMPAIGN_LISTING_PAGE_SOURCE, pageSource)
-    }
+    private val campaignViewModel: CampaignViewModel by activityViewModels()
 
     override fun onCreateView(
         inflater: LayoutInflater, container: ViewGroup?,
@@ -112,7 +97,7 @@ class CampaignListingFragment : Fragment() {
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-        viewModel.start(pageSource!!)
+        viewModel.start(getPageSource())
         initObservers()
     }
 
@@ -140,6 +125,11 @@ class CampaignListingFragment : Fragment() {
         }
     }
 
+    private fun getPageSource(): CampaignListingPageSource {
+        return arguments?.getSerializableCompat<CampaignListingPageSource>(CAMPAIGN_LISTING_PAGE_SOURCE)
+            ?: CampaignListingPageSource.UNKNOWN
+    }
+
     @OptIn(ExperimentalMaterial3Api::class)
     @Composable
     fun CampaignListingPage(uiState: CampaignListingUiState) {
@@ -317,4 +307,3 @@ fun CampaignListingErrorPreview() {
         ))
     }
 }
-