Skip to content

Commit

Permalink
Refactor reader primary button color resource names
Browse files Browse the repository at this point in the history
  • Loading branch information
Thomas Horta committed Jan 26, 2024
1 parent 28382cc commit 7fca92c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>

<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:color="@color/reader_subfilter_button_background" android:state_enabled="true" />
<item android:alpha="@dimen/primary_button_disabled_alpha" android:color="@color/reader_subfilter_button_background" />
<item android:color="@color/reader_button_primary_background" android:state_enabled="true" />
<item android:alpha="@dimen/primary_button_disabled_alpha" android:color="@color/reader_button_primary_background" />
</selector>
4 changes: 2 additions & 2 deletions WordPress/src/main/res/values-night/colors.xml
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@
<color name="reader_blog_section_avatar_internal_border">@color/white_translucent_20</color>
<color name="reader_post_body_link">@color/blue_30</color>
<color name="reader_footer_progress_background">@color/background_dark_elevated</color>
<color name="reader_subfilter_button_background">@color/white</color>
<color name="reader_subfilter_button_text">@color/black</color>
<color name="reader_button_primary_background">@color/white</color>
<color name="reader_button_primary_text">@color/black</color>

<!-- Reader Interest Chips -->
<color name="reader_interest_filter_chip_text_checked">@color/black</color>
Expand Down
4 changes: 2 additions & 2 deletions WordPress/src/main/res/values/colors.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@
<color name="reader_blog_section_avatar_internal_border">@color/black_translucent_20</color>
<color name="reader_post_body_link">@color/blue_50</color>
<color name="reader_footer_progress_background">@color/white</color>
<color name="reader_subfilter_button_background">@color/black</color>
<color name="reader_subfilter_button_text">@color/white</color>
<color name="reader_button_primary_background">@color/black</color>
<color name="reader_button_primary_text">@color/white</color>

<!-- Reader Interest Chips -->
<color name="reader_interest_filter_chip_text">@color/material_on_surface_emphasis_high_type</color>
Expand Down
4 changes: 2 additions & 2 deletions WordPress/src/main/res/values/reader_styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@
<!-- Buttons -->
<style name="Reader.Button.Primary" parent="Widget.MaterialComponents.Button.UnelevatedButton">
<item name="android:textAllCaps">false</item>
<item name="android:backgroundTint">@color/reader_button_background_selector</item>
<item name="android:textColor">@color/reader_subfilter_button_text</item>
<item name="android:backgroundTint">@color/reader_button_primary_background_selector</item>
<item name="android:textColor">@color/reader_button_primary_text</item>
<item name="android:textAppearance">?attr/textAppearanceSubtitle2</item>
<item name="android:textSize">@dimen/text_sz_large</item>
<item name="android:paddingTop">@dimen/margin_large</item>
Expand Down

0 comments on commit 7fca92c

Please sign in to comment.