Skip to content

Commit

Permalink
Merge pull request #21431 from wordpress-mobile/remove_violations_gra…
Browse files Browse the repository at this point in the history
…dle_plugin

Remove `violations-comments-to-github-gradle-plugin`
  • Loading branch information
nbradbury authored Nov 6, 2024
2 parents d252c35 + db72cf8 commit b2cb39b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 32 deletions.
29 changes: 0 additions & 29 deletions WordPress/build.gradle
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
import io.sentry.android.gradle.extensions.InstrumentationFeature
import se.bjurr.violations.comments.github.plugin.gradle.ViolationCommentsToGitHubTask
import se.bjurr.violations.lib.model.SEVERITY

plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.kotlin.parcelize)
alias(libs.plugins.kotlin.allopen)
alias(libs.plugins.sentry)
alias(libs.plugins.violation.comments)
alias(libs.plugins.google.services)
alias(libs.plugins.google.dagger.hilt)
alias(libs.plugins.kotlinx.kover)
Expand Down Expand Up @@ -593,32 +590,6 @@ if ((file('google-services.json').text) == (file('google-services.json-example')
println("WARNING: You're using the example google-services.json file. Google login will fail.")
}

tasks.register("violationCommentsToGitHub", ViolationCommentsToGitHubTask) {
repositoryOwner = "wordpress-mobile"
repositoryName = "WordPress-Android"
pullRequestId = System.properties['GITHUB_PULLREQUESTID']
username = System.properties['GITHUB_USERNAME']
password = System.properties['GITHUB_PASSWORD']
oAuth2Token = System.properties['GITHUB_OAUTH2TOKEN']
gitHubUrl = "https://api.github.com/"
createCommentWithAllSingleFileComments = false
createSingleFileComments = true
commentOnlyChangedContent = true
minSeverity = SEVERITY.INFO //ERROR, INFO, WARN
commentTemplate = """
**Reporter**: {{violation.reporter}}{{#violation.rule}}\n
**Rule**: {{violation.rule}}{{/violation.rule}}
**Severity**: {{violation.severity}}
**File**: {{violation.file}}:{{violation.startLine}}{{#violation.source}}
**Source**: {{violation.source}}{{/violation.source}}
{{violation.message}}
"""
violations = [
["CHECKSTYLE", ".", ".*/build/.*/checkstyle/.*\\.xml\$", "CheckStyle"],
["CHECKSTYLE", ".", ".*/build/.*/detekt/.*\\.xml\$", "Detekt"]
]
}

tasks.register("printVersionName") {
doLast {
println android.defaultConfig.versionName
Expand Down
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ plugins {
alias(libs.plugins.automattic.measure.builds)
alias(libs.plugins.kotlinx.kover)
alias(libs.plugins.dependency.analysis)
alias(libs.plugins.violation.comments).apply(false)
alias(libs.plugins.androidx.navigation.safeargs).apply(false)
alias(libs.plugins.android.application).apply(false)
alias(libs.plugins.android.library).apply(false)
Expand Down
2 changes: 0 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ squareup-java-poet = '1.13.0'
squareup-kotlin-poet = '1.18.1'
squareup-okhttp3 = '4.12.0'
squareup-retrofit = '2.11.0'
violation-comments = '1.70.0'
wellsql = '2.0.0'
wiremock = '2.26.3'
wordpress-aztec = 'v2.1.4'
Expand Down Expand Up @@ -281,4 +280,3 @@ kotlinx-kover = { id = "org.jetbrains.kotlinx.kover", version.ref = "kotlinx-kov
ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
sentry = { id = "io.sentry.android.gradle", version.ref = "sentry" }
room = { id = "androidx.room", version.ref = "androidx-room" }
violation-comments = { id = "se.bjurr.violations.violation-comments-to-github-gradle-plugin", version.ref = "violation-comments" }

0 comments on commit b2cb39b

Please sign in to comment.