-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecates old in-line notification icons #20068
Deprecates old in-line notification icons #20068
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 dangerJS |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/notifications_refresh_p1 #20068 +/- ##
=====================================================================
+ Coverage 40.25% 54.59% +14.34%
=====================================================================
Files 1455 14 -1441
Lines 66832 522 -66310
Branches 11034 52 -10982
=====================================================================
- Hits 26903 285 -26618
+ Misses 37438 219 -37219
+ Partials 2491 18 -2473 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the bunch of stuff, Antonis. I tested it on my Pixel and noticed no badges. The rest works as expected. 🚀
Thank you for reviewing @justtwago 🙇 |
Fixes #20022
Description
This PR removes the notification avatar icons along with the related code and resources
To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: