-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tags Feed] Implement pull-to-refresh #20791
Conversation
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @thomashorta 🙇 ! Code is clean and looks good (good job 👍 ).
I tested the PR as per steps and it works correctly. Also checked the posts featured images are now loaded as expected (good catch 👍 ).
I'm approving and we can merge this PR 🎉 .
Side note: while testing I noticed something that is not related to this PR (if it's not on the radar already I can create a separate GH issue for later, just let me know 👍 ).
The position in the feed resets to the top of the feed on screen rotation (it seems consistent). This might be annoying when you have many tags you follow and you are deep down the feed and sent to the top. We have more urgent tasks to cover, but as said I'm happy to create a GH issue if needed so we do not forget to improve this along the way 🙇 .
...main/java/org/wordpress/android/ui/reader/viewmodels/tagsfeed/ReaderTagsFeedUiStateMapper.kt
Show resolved
Hide resolved
...src/main/java/org/wordpress/android/ui/reader/viewmodels/tagsfeed/ReaderTagsFeedViewModel.kt
Show resolved
Hide resolved
313b4a1
to
03d53da
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue/20708-tags-feed-lazy-load #20791 +/- ##
================================================================
Coverage 40.78% 40.79%
================================================================
Files 1493 1493
Lines 68627 68642 +15
Branches 11335 11337 +2
================================================================
+ Hits 27991 28003 +12
- Misses 38093 38095 +2
- Partials 2543 2544 +1 ☔ View full report in Codecov by Sentry. |
Just leaving a note that I created a GH issue here for the screen rotation issue identified in this comment as per our slack alignment. |
Fixes #20707
Add pull-to-refresh to Tags Feed, which reloads the user's sites and tags then "restarts" the Tags Feed, fetching newer posts for each of the tags.
This also fixes the wrong post image being shown (it was showing the site avatar instead of the featured image).
To Test:
reader_tags_feed
feature configTags
feedTags
feedNote: also verify that the post images are now correct.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):