-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds: delays for app restart in InAppUpdateManagerImpl #20936
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/25.0 #20936 +/- ##
================================================
- Coverage 41.06% 41.06% -0.01%
================================================
Files 1515 1515
Lines 69426 69429 +3
Branches 11451 11451
================================================
+ Hits 28507 28508 +1
- Misses 38338 38340 +2
Partials 2581 2581 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pantstamp
Tested the PR as per instructions, the event is tracked now
Tracked: in_app_update_completed_with_app_restart
This PR fixes a bug that was discovered after the pe7hp4-R0-p2.
During the flexible flow, when user has accepted the update and it is being downloaded in the background while the app is in the foreground, once it is ready to install, a snackbar appears with a "Restart" action. We want to log an event there before the app is restarted.
This PR adds a delay between the logging of the event the app's restart so the logging have enough time to complete.
cc @oguzkocer
To Test:
Check PR here for more details.
ATTENTION: The current remote config value is 80000. This means that when you try to update a version of the app that is < 80000, the immediate flow will be launched.
To test this feature, we use Internal app sharing as Google suggests here.
Please read how Internal app sharing works here.
ATTENTION: As app bundle links in Internal app sharing might expire, you may need to reupload an app bundle to get a new link to use. The page for uploading is here. If you have the Release apps to testing tracks permission, you’re authorized to upload app bundles and APKs for internal sharing by default. If you don't, you can make a request in Systems P2 like pMz3w-jQU-p2.
19.Check that a snackbar appears that informs the user and asking for a restart.
21. Check that the IN_APP_UPDATE_COMPLETED_WITH_APP_RESTART_BY_USER event is tracked.
Attention: If the app is in the background when the update is downloaded, the update is installed silently without notifying the user.