Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce tests sharding #21101
Introduce tests sharding #21101
Changes from 10 commits
168a994
ceb5d82
e96ee1a
99d5c67
9e6afa0
3e93f61
14ba431
d36b4a9
3d7c853
cd01ef0
a462b4d
4882026
7c69f45
9616d52
cc83564
c1ef744
cc4cc3b
10c9a74
997e808
e7d901b
4d7c0b7
9c05ddd
40986a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iangmaia could you please confirm if it's okay to ignore? I want to rescue from all possible causes of
gradle
orsh
crash.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those would still be caught if using
rescue StandardError
?By the way, mentioning just in case (not sure if it would make more sense here, as you also have the
gradle
call): forsh
, you can also use aerror_callback
parameter if you want to do a custom handling in case the command returns an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True,
rescue StandardError
worked fine, thanks! Addressed in 997e808About
error_callback
- I don't see it being mentioned ingradle
action documentation, and Gradle part is the most crucial part of this handling so I think we could keep this try/catch approach