-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rs.wordpress.api:android
dependency
#21108
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
bbed50f
to
fe4572f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21108 +/- ##
==========================================
- Coverage 40.49% 40.48% -0.01%
==========================================
Files 1530 1530
Lines 69818 69821 +3
Branches 11443 11443
==========================================
Hits 28270 28270
- Misses 39094 39097 +3
Partials 2454 2454 ☔ View full report in Codecov by Sentry. |
1435cdc
to
c45fd95
Compare
c45fd95
to
d2a6d63
Compare
Found 1 violations: The PR caused some dependency changes (expand to see details)
-+--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.0 (*)
++--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.0 (*)
+--- project :libs:image-editor
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.0 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.0 (*)
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 -> 1.9.25
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 1.9.25
+--- project :libs:editor
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.0 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.0 (*)
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 -> 1.9.25 (*)
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 1.9.25 (*)
+--- org.wordpress:fluxc:{strictly trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42} -> trunk-94d25d35fb4bf58a2e90741a6a5d56b8c6c3ce42
-| \--- net.java.dev.jna:jna:5.5.0
+| \--- net.java.dev.jna:jna:5.5.0 -> 5.14.0
-\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 -> 1.9.25 (*)
++--- rs.wordpress.api:android:trunk-50f703a7f677084157d02f05d4d477d7eaf960b1
+| +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| +--- net.java.dev.jna:jna:5.14.0
+| +--- rs.wordpress.api:kotlin:trunk-50f703a7f677084157d02f05d4d477d7eaf960b1
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.0 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.0 (*)
+\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.24 -> 1.9.25 (*)
Please review and act accordingly
|
This will help us understand if it’s working or not
@@ -1,6 +1,6 @@ | |||
pluginManagement { | |||
gradle.ext.kotlinVersion = '1.9.22' | |||
gradle.ext.kspVersion = '1.9.22-1.0.17' | |||
gradle.ext.kotlinVersion = '1.9.24' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to update the kotlinVersion
and kspVersion
in this PR? That seems like something that should be handled separately.
Likewise with androidxComposeCompilerVersion
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was bumped to align with the https://github.com/automattic/wordpress-rs project,t which used very slightly newer versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected when I use vanilla.wpmt.co
but when I use google.com
, instead of seeing "auto discovery is not successful" in logcat, I see "onDiscoveryResponse has error: XMLRPC_BLOCKED - XMLRPC_BLOCKED."
In fact, in this situation LoginActivity.gotXmlRpcEndpoint
isn't called. Is this expected?
Ah, yep - this is expected, sorry - |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkmassel This is looking good to go! Feel free to merge when ready.
This PR adds the WordPress.rs library and uses it to attempt URL auto discovery for new XMLRPC sites that are added to the apps. This should be a very small number of users, and it's performed in the background so it shouldn't affect UX.
To Test: