Feature: Feedback form attachments #21114

nbradbury · 2024-08-05T12:57:37Z

This is the feature branch for uploading feedback form attachments. It contains the following child PRs:

To test:

Tap Help on the Me page and ensure the "Contact email" is correct (this for step 6)
Return to the Me page and tap "Send feedback"
Enter a message
Add a couple of attachments
Tap submit and verify it all works
When you get the email about the ticket, go to https://a8c.zendesk.com/agent/tickets/$ticketNumber and verify the attachments were added

Caveats:

Unlike iOS, there is no preview of attachments yet - that's being worked on separately in this branch
Like iOS, there isn't a way to cancel the attachment uploading. I suspect we'll want to add this at some point.

…GLE_MEDIA_PICKER

…m/wordpress-mobile/WordPress-Android into issue/21105-feedback-form-attachments-ui

…form-attachments-ui Feedback form attachments UI

…m/wordpress-mobile/WordPress-Android into issue/21105-feedback-form-upload-attachments

dangermattic · 2024-08-05T13:00:51Z

	7 Warnings
⚠️	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	Class `ZendeskUploadHelper` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `ProgressDialogState` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `FeedbackFormAttachment` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	Class `FeedbackFormUtils` is missing tests, but `unit-tests-exemption` label was set to ignore this.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2024-08-05T13:15:22Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21114-bd868ee
	Commit	`bd868ee`
	Direct Download	`jetpack-prototype-build-pr21114-bd868ee.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-08-05T13:16:38Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21114-bd868ee
	Commit	`bd868ee`
	Direct Download	`wordpress-prototype-build-pr21114-bd868ee.apk`

Note: Google Login is not supported on these builds.

…m/wordpress-mobile/WordPress-Android into issue/21105-feedback-form-suspend-cancel Conflicts: WordPress/src/main/java/org/wordpress/android/support/ZendeskUploadHelper.kt

…form-suspend-cancel Feedback form: suspend cancel upload

dcalhoun

Nice work!

I tested the flow in both the Jetpack and WordPress mobile apps on a Samsung Galaxy S20. I tested the happy path and disrupting submissions with network conditions. I did not encounter any significant issues.

In the WordPress app, there is no contact email. I presume we want to allow users to submit anonymous feedback from this app. Is that accurate?

I left a couple of suggestions, but I do not consider them blockers. Also, feel free to seek additional Android code feedback if you'd like.

WordPress/src/main/java/org/wordpress/android/ui/main/feedbackform/FeedbackFormScreen.kt

WordPress/src/main/java/org/wordpress/android/ui/main/feedbackform/FeedbackFormViewModel.kt

sonarqubecloud · 2024-08-08T17:17:32Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nbradbury · 2024-08-08T17:24:22Z

@dcalhoun Thanks for the review!

I noted the message box is not auto-focused and does not enable shift key be focused...Should we consider implementing that here?

Agreed. I've added auto-focus but I'm not sure why sentence capitalization isn't working since I'm requesting it. ~~I'll keep looking into that, but I may file a separate issue for it to avoid holding up this PR.~~ Update: it turns out I was doing it right in bd868ee after all, so problem solved.

I encountered this error when attempt to attach an image when "browsing" files on a Samsung Galaxy S20

Very good catch! I was able to reproduce this when browsing on my Pixel 7a and fixed it in ddfb08b.

nbradbury · 2024-08-08T17:45:16Z

In the WordPress app, there is no contact email. I presume we want to allow users to submit anonymous feedback from this app. Is that accurate?

That's accurate, but is subject to change.

nbradbury and others added 24 commits August 1, 2024 09:00

Copied some basic attachment code from DOAndroid

f1a13b1

Added basic attachments section and photo picker

c246e15

Rewrote preview

3710c95

Fixed attachment button

e29cac9

Removed separate attachment section

d8dd260

Added attachment to preview, added MediaBrowserType.FEEDBACK_FORM_SIN…

07ee28f

…GLE_MEDIA_PICKER

Cleaned up FeedbackFormScreenPreview

8383a73

Fixed ReturnCount warning in addAttachment

bc42af8

Fixed detekt warnings in Uri.copyToTempFile

e5da5d9

Fixed remaining detekt warnings in UriExt

7ab87bd

Added comments to UriExt

b3ecb05

Add single selected media attachments

1e20148

Allow multi select

5773352

Merge branch 'feature/feedback-form-attachments' of https://github.co…

99eada1

…m/wordpress-mobile/WordPress-Android into issue/21105-feedback-form-attachments-ui

Always use showToast fun

1a32b3d

Fixed checkstyle issue with FeedbackFormUtils

00a98df

Fixed failing test

cfd656a

Simplified attachment types to just image & video

bac9c1a

Include attachments in discard confirmation

c973e6d

Merge pull request #21107 from wordpress-mobile/issue/21105-feedback-…

554c512

…form-attachments-ui Feedback form attachments UI

Added attachment IDs

9b5164f

First pass at ZendeskUploadHelper

a624caa

Fixed warnings

4d42520

Make attachmentIds optional

398c6a6

nbradbury added the User Feedback Users need something added or fixed label Aug 5, 2024

nbradbury and others added 2 commits August 5, 2024 08:57

Merge branch 'trunk' into feature/feedback-form-attachments

46357d7

Merge branch 'feature/feedback-form-attachments' of https://github.co…

bd19684

…m/wordpress-mobile/WordPress-Android into issue/21105-feedback-form-upload-attachments

nbradbury and others added 14 commits August 7, 2024 12:38

Make sure continuation is active before resuming

e3d7f84

Removed redundant logging

13413b0

Fixed checkstyle issue

bb4e62a

Merge branch 'feature/feedback-form-attachments' of https://github.co…

bca0784

…m/wordpress-mobile/WordPress-Android into issue/21105-feedback-form-suspend-cancel Conflicts: WordPress/src/main/java/org/wordpress/android/support/ZendeskUploadHelper.kt

Improved preview

8537ceb

Minor preview change

49e1886

Don't continue adding attachments when one fails

85dba34

Changed MAX_SINGLE_ATTACHMENT_SIZE to match iOS

bfa6f18

Removed max total attachment size to match iOS

26ab4dc

Changed MAX_ATTACHMENTS to 5 to match iOS

a6b7358

Don't hard-code the size limit in the string resource

308ba00

Fixed failing test

6602624

Merge pull request #21119 from wordpress-mobile/issue/21105-feedback-…

57cfc7e

…form-suspend-cancel Feedback form: suspend cancel upload

Merge branch 'trunk' into feature/feedback-form-attachments

9d70667

nbradbury marked this pull request as ready for review August 8, 2024 12:52

nbradbury mentioned this pull request Aug 8, 2024

Feedback form: attachment pager #21121

Merged

nbradbury assigned dcalhoun, jkmassel and geriux Aug 8, 2024

dcalhoun self-requested a review August 8, 2024 13:37

dcalhoun approved these changes Aug 8, 2024

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/main/feedbackform/FeedbackFormScreen.kt Outdated Show resolved Hide resolved

WordPress/src/main/java/org/wordpress/android/ui/main/feedbackform/FeedbackFormViewModel.kt Show resolved Hide resolved

nbradbury added 4 commits August 8, 2024 12:24

Auto-focus the message field

45bf19c

Fix file:// URIs

ddfb08b

Corrected typo in comment

2f62673

Use KeyboardCapitalization.Sentences

bd868ee

nbradbury merged commit 27b43d3 into trunk Aug 8, 2024
20 checks passed

nbradbury deleted the feature/feedback-form-attachments branch August 8, 2024 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Feedback form attachments #21114

Feature: Feedback form attachments #21114

nbradbury commented Aug 5, 2024 •

edited

Loading

dangermattic commented Aug 5, 2024 •

edited

Loading

wpmobilebot commented Aug 5, 2024 •

edited

Loading

wpmobilebot commented Aug 5, 2024 •

edited

Loading

dcalhoun left a comment

sonarqubecloud bot commented Aug 8, 2024

nbradbury commented Aug 8, 2024 •

edited

Loading

nbradbury commented Aug 8, 2024

Feature: Feedback form attachments #21114

Feature: Feedback form attachments #21114

Conversation

nbradbury commented Aug 5, 2024 • edited Loading

dangermattic commented Aug 5, 2024 • edited Loading

wpmobilebot commented Aug 5, 2024 • edited Loading

wpmobilebot commented Aug 5, 2024 • edited Loading

dcalhoun left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Aug 8, 2024

Quality Gate passed

nbradbury commented Aug 8, 2024 • edited Loading

nbradbury commented Aug 8, 2024

nbradbury commented Aug 5, 2024 •

edited

Loading

dangermattic commented Aug 5, 2024 •

edited

Loading

wpmobilebot commented Aug 5, 2024 •

edited

Loading

wpmobilebot commented Aug 5, 2024 •

edited

Loading

nbradbury commented Aug 8, 2024 •

edited

Loading