-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Update Ruby Dependencies #21129
Conversation
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Uh, it seems that #21121 is the one that accidentally reverted changes to the I think that happened because @nbradbury 's PR branch was initially created a while ago (and thus that branch had been cut before we updated the gems in #21120 and landed that one in And also, still not sure why this made Git and GitHub not show any changes in the Git History of the Anyway, glad I managed to get to the bottom of what happened, even if I'm not sure why |
I'd also expect GitHub to have a feature of "you're trying to merge a PR with reported security vulnerability" out of the box 😓 . Maybe we could consider integrating https://github.com/actions/dependency-review-action ? |
This should address the currently 3 opened Dependabot alerts about Ruby gems—in particular about
rexml
:Git Oddity?!
@spencertransier already created and merged #21120 a couple of days ago, which was supposed to have solved those already.
Yet, looking at the current Git History of the
Gemfile.lock
fromtrunk
, the merge commit for #21120 doesn't appear anywhere 🤔 😕Especially even if the changes from #21120 had for some reason been reverted, or overwritten by a subsequent PR doing unrelated changes to
Gemfile.lock
and accidentally undoing the changes from https://github.com/wordpress-mobile/WordPress-Android/pull/21120… we'd also see that in the git history for theGemfile.lock
, right?Anyway, not sure what happened here, but I figured it'd still make sense to re-do that gem update in any case.