Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self hosted users feature flag #21259

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Sep 25, 2024

This PR simply adds the "self hosted users" feature flag to our debug settings. To test:

  • Me > Debug settings
  • Toggle the enable_self_hosted_users checkbox
  • Ensure the checkbox state is remembered

toggle

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 25, 2024

2 Warnings
⚠️ Class SelfHostedUsersFeatureConfig is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 25, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21259-0cf9a3e
Commit0cf9a3e
Direct Downloadjetpack-prototype-build-pr21259-0cf9a3e.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 25, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21259-0cf9a3e
Commit0cf9a3e
Direct Downloadwordpress-prototype-build-pr21259-0cf9a3e.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.46%. Comparing base (2210956) to head (0cf9a3e).
Report is 11 commits behind head on trunk.

Files with missing lines Patch % Lines
...ndroid/util/config/SelfHostedUsersFeatureConfig.kt 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21259   +/-   ##
=======================================
  Coverage   40.46%   40.46%           
=======================================
  Files        1530     1531    +1     
  Lines       69826    69831    +5     
  Branches    11443    11444    +1     
=======================================
+ Hits        28255    28259    +4     
- Misses      39124    39125    +1     
  Partials     2447     2447           
Flag Coverage Δ
40.46% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury marked this pull request as ready for review September 25, 2024 23:11
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan succeeded for me on a Samsung Galaxy S20. 🚀

Copy link

@nbradbury nbradbury merged commit 6b99ae8 into trunk Sep 26, 2024
20 of 21 checks passed
@nbradbury nbradbury deleted the issue/self-hosted-users-feature-flag branch September 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants