-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self hosted users feature flag #21259
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21259 +/- ##
=======================================
Coverage 40.46% 40.46%
=======================================
Files 1530 1531 +1
Lines 69826 69831 +5
Branches 11443 11444 +1
=======================================
+ Hits 28255 28259 +4
- Misses 39124 39125 +1
Partials 2447 2447
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test plan succeeded for me on a Samsung Galaxy S20. 🚀
WordPress/src/main/java/org/wordpress/android/util/config/ExperimentConfig.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/util/config/SelfHostedUsersFeatureConfig.kt
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
This PR simply adds the "self hosted users" feature flag to our debug settings. To test:
enable_self_hosted_users
checkbox