Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-hosted userlist #21264

Closed
wants to merge 32 commits into from
Closed

Self-hosted userlist #21264

wants to merge 32 commits into from

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Sep 26, 2024

This PR adds a screen for the self-hosted user list. Note that dummy data is being used here. Actual data requested via wordpress-rs will come later.

To test:

  • Enable self_hosted_users in debug settings
  • Switch to a self-hosted site
  • Note that a new "Users" item appears
  • Tap on that and verify the screen with dummy data looks fine
  • Switch to a non-self-hosted site and verify the "Users" item doesn't appear
  • View the various Compose previews of the UserListScreen and verify they look fine (note that remote avatar images won't load in the preview)

This is ready for review but should not be merged because I use an image from my blog in the preview. I'll remove that after the PR is approved and then I'll merge it.

users

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 26, 2024

5 Warnings
⚠️ strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class SelfHostedUsersViewModel is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class SelfHostedUserState is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 26, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21264-08671a4
Commit08671a4
Direct Downloadwordpress-prototype-build-pr21264-08671a4.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 26, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21264-08671a4
Commit08671a4
Direct Downloadjetpack-prototype-build-pr21264-08671a4.apk
Note: Google Login is not supported on these builds.

@@ -724,6 +725,15 @@
AnalyticsUtils.trackWithSiteDetails(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT, site);
}

public static void viewSelfHostedUsers(Context context, SiteModel site) {

Check notice

Code scanning / Android Lint

Nullable/NonNull annotation missing on method parameter Note

Missing null annotation
@@ -724,6 +725,15 @@
AnalyticsUtils.trackWithSiteDetails(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT, site);
}

public static void viewSelfHostedUsers(Context context, SiteModel site) {

Check notice

Code scanning / Android Lint

Nullable/NonNull annotation missing on method parameter Note

Missing null annotation
@nbradbury nbradbury changed the title Self-hosted userlist [WIP] Self-hosted userlist Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 2.18341% with 224 lines in your changes missing coverage. Please review.

Project coverage is 40.34%. Comparing base (8152531) to head (08671a4).

Files with missing lines Patch % Lines
...id/ui/selfhostedusers/SelfHostedUserComposables.kt 0.00% 65 Missing ⚠️
...ndroid/ui/selfhostedusers/SelfHostedUsersScreen.kt 0.00% 65 Missing ⚠️
...ordpress/android/ui/selfhostedusers/SampleUsers.kt 0.00% 64 Missing ⚠️
...oid/ui/selfhostedusers/SelfHostedUsersViewModel.kt 0.00% 19 Missing ⚠️
...id/ui/mysite/items/listitem/SiteListItemBuilder.kt 33.33% 6 Missing ⚠️
...ava/org/wordpress/android/ui/ActivityLauncher.java 0.00% 3 Missing ⚠️
...ordpress/android/ui/mysite/SiteNavigationAction.kt 0.00% 1 Missing ⚠️
...s/android/ui/mysite/cards/ListItemActionHandler.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #21264      +/-   ##
==========================================
- Coverage   40.46%   40.34%   -0.13%     
==========================================
  Files        1531     1535       +4     
  Lines       69831    70059     +228     
  Branches    11444    11493      +49     
==========================================
+ Hits        28259    28262       +3     
- Misses      39125    39350     +225     
  Partials     2447     2447              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Sep 27, 2024
@nbradbury nbradbury marked this pull request as ready for review September 27, 2024 17:52
@nbradbury nbradbury removed the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Sep 27, 2024
@nbradbury nbradbury changed the title [WIP] Self-hosted userlist Self-hosted userlist Sep 30, 2024
Copy link

sonarqubecloud bot commented Oct 1, 2024

@nbradbury nbradbury mentioned this pull request Oct 3, 2024
@nbradbury
Copy link
Contributor Author

Closing in favor of #21275

@nbradbury nbradbury closed this Oct 3, 2024
@dcalhoun dcalhoun deleted the issue/self-hosted-userlist branch October 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants