-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-hosted userlist #21264
Self-hosted userlist #21264
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
@@ -724,6 +725,15 @@ | |||
AnalyticsUtils.trackWithSiteDetails(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT, site); | |||
} | |||
|
|||
public static void viewSelfHostedUsers(Context context, SiteModel site) { |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on method parameter Note
@@ -724,6 +725,15 @@ | |||
AnalyticsUtils.trackWithSiteDetails(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT, site); | |||
} | |||
|
|||
public static void viewSelfHostedUsers(Context context, SiteModel site) { |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on method parameter Note
… issue/self-hosted-userlist
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21264 +/- ##
==========================================
- Coverage 40.46% 40.34% -0.13%
==========================================
Files 1531 1535 +4
Lines 69831 70059 +228
Branches 11444 11493 +49
==========================================
+ Hits 28259 28262 +3
- Misses 39125 39350 +225
Partials 2447 2447
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Closing in favor of #21275 |
This PR adds a screen for the self-hosted user list. Note that dummy data is being used here. Actual data requested via
wordpress-rs
will come later.To test:
self_hosted_users
in debug settingsUserListScreen
and verify they look fine (note that remote avatar images won't load in the preview)This is ready for review but should not be merged because I use an image from my blog in the preview. I'll remove that after the PR is approved and then I'll merge it.