Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Social: Hide Jetpack Social for private posts #21362

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

wargcm
Copy link
Contributor

@wargcm wargcm commented Aug 17, 2023

Fixes #21290

Description

Hides Jetpack social when the post is private in the pre-publishing sheet and post settings screen.

Testing

To test:

  • Launch Jetpack and login
  • Select a blog with no social connections
  • Create a new post
  • Open the Post Settings screen (... > Post Settings)
  • 🔍 Verify the no social connections view is shown
  • Tap on Visibility
  • Select Private
  • 🔍 Verify the no social connections view is not shown
  • Navigate back to the post
  • Type something in to enable the Publish button and tap on it
  • 🔍 Verify the no social connections view is not shown
  • Tap on Visibility
  • Select Public
  • 🔍 Verify the no social connections view is shown
  • Discard the post
  • Switch to a blog which has social connections or set one up
  • Repeat the above steps but verify with the social sharing views

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wargcm wargcm added this to the 23.1 milestone Aug 17, 2023
@wargcm wargcm requested a review from dvdchr August 17, 2023 23:24
@wargcm wargcm self-assigned this Aug 17, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21362-12a3aa7
Version23.0
Bundle IDorg.wordpress.alpha
Commit12a3aa7
App Center BuildWPiOS - One-Offs #6755
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21362-12a3aa7
Version23.0
Bundle IDcom.jetpack.alpha
Commit12a3aa7
App Center Buildjetpack-installable-builds #5791
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wargcm wargcm modified the milestones: 23.1, 23.2 Aug 18, 2023
@dvdchr dvdchr changed the base branch from trunk to release/23.1 August 21, 2023 06:47
Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the Jetpack Social section is no longer shown for private posts. LGTM! :shipit:

FYI: I've updated the base branch to release/23.1 since it's a pretty small change.

@wargcm wargcm modified the milestones: 23.2, 23.1 ❄️ Aug 21, 2023
@wargcm
Copy link
Contributor Author

wargcm commented Aug 21, 2023

Thanks @dvdchr!

@wargcm wargcm merged commit 4196edc into release/23.1 Aug 21, 2023
@wargcm wargcm deleted the issue/21290-hide-social-on-private-posts branch August 21, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Social section is visible on private posts
3 participants