Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Page hierarchy #21853

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 23, 2023

Fixes ##21818

To test:

  • Verify that pages with parents are rendered with indentation

Known issues:

Screenshot 2023-10-23 at 5 21 12 PM

Regression Notes

  1. Potential unintended areas of impact: Pages List
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 23, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21853-a4ddecd
Version23.4
Bundle IDorg.wordpress.alpha
Commita4ddecd
App Center BuildWPiOS - One-Offs #7520
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 23, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21853-a4ddecd
Version23.4
Bundle IDcom.jetpack.alpha
Commita4ddecd
App Center Buildjetpack-installable-builds #6548
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean changed the title Task/pages hierarchy Posts & Pages: Page hierarchy Oct 23, 2023
@kean kean requested a review from momo-ozawa October 23, 2023 22:45
@kean kean added this to the 23.6 milestone Oct 23, 2023
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the subdirectory icon tint color should be lighter? (ref: https://a8c.slack.com/archives/C04SFL0RP51/p1697134579124589)

Otherwise, LGTM!

@@ -11,6 +11,8 @@ final class PageListCell: UITableViewCell, Reusable {
private let badgesLabel = UILabel()
private let featuredImageView = CachedAnimatedImageView()
private let ellipsisButton = UIButton(type: .custom)
private let contentStackView = UIStackView()
private var indentionIconView = UIImageView()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]

Suggested change
private var indentionIconView = UIImageView()
private var indentationIconView = UIImageView()

@kean
Copy link
Contributor Author

kean commented Oct 24, 2023

Fixed both of the issues! 📦

@kean kean merged commit 5438098 into task/ui-modernization-posts-and-pages Oct 24, 2023
@kean kean deleted the task/pages-hierarchy branch October 24, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants