Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve editor session events #23955

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 7, 2025

  • Introduce gutenberg_kit editor session event property value.
  • Track editor session start event for GutenbergKit sessions.

Related:

To test:

  1. Open the experimental editor.
  2. Close the editor.
  3. Verify editor_session_start|end events trigger with a
    editor: gutenberg_kit property.

Regression Notes

  1. Potential unintended areas of impact
    Disrupt events for the other editors.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Verify the editor session events work as expected.
  3. What automated tests I added (or what prevented me from doing so)
    Deemed unnecessary for this experimental editor analytic event.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

Denote sessions utilizing the GutenbergKit editor.
Enable more robust editor session analysis.
@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Jan 7, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 7, 2025

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 7, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23955-283ee9d
Version25.6
Bundle IDorg.wordpress.alpha
Commit283ee9d
App Center BuildWPiOS - One-Offs #11305
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 7, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23955-283ee9d
Version25.6
Bundle IDcom.jetpack.alpha
Commit283ee9d
App Center Buildjetpack-installable-builds #10338
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun enabled auto-merge January 8, 2025 14:05
@dcalhoun dcalhoun added this pull request to the merge queue Jan 8, 2025
Merged via the queue into trunk with commit 0ea3205 Jan 8, 2025
25 checks passed
@dcalhoun dcalhoun deleted the feat/improve-editor-session-event-properties branch January 8, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants