Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show selected filter in the Discover navigation bar #23956

Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 7, 2025

This PR takes advantages of the custom title view we introduced previously to show the selected filter/channel.

Screenshot 2025-01-07 at 1 06 01 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Jan 7, 2025
@kean kean added this to the 25.7 milestone Jan 7, 2025
@kean kean merged commit f0e5730 into christmas-feature-branch Jan 7, 2025
0 of 11 checks passed
@kean kean deleted the task/show-seledted-filter-in-discover branch January 7, 2025 18:08
@kean kean mentioned this pull request Jan 7, 2025
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23956-5fd1a43
Version25.6
Bundle IDorg.wordpress.alpha
Commit5fd1a43
App Center BuildWPiOS - One-Offs #11294
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants