Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll-to-top button to Reader streams #23957

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Add scroll-to-top button to Reader streams #23957

merged 6 commits into from
Jan 7, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 7, 2025 •
edited
Loading

Fixes #23952.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-07.at.17.28.27.mp4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Jan 7, 2025
@kean kean added this to the 25.7 milestone Jan 7, 2025
@kean kean force-pushed the task/add-scroll-to-top branch from 44622ea to 6ead7b3 Compare January 7, 2025 22:37
@kean kean changed the title Add scroll-to-top button Add scroll-to-top button to Reader streams Jan 7, 2025
@kean kean changed the base branch from trunk to christmas-feature-branch January 7, 2025 22:38
@kean kean mentioned this pull request Jan 7, 2025
Open
14 tasks
@kean kean merged commit 46d183f into christmas-feature-branch Jan 7, 2025
5 of 20 checks passed
@kean kean deleted the task/add-scroll-to-top branch January 7, 2025 22:39
@kean kean mentioned this pull request Jan 7, 2025
Closed
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23957-2069c49
Version25.6
Bundle IDorg.wordpress.alpha
Commit2069c49
App Center BuildWPiOS - One-Offs #11298
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23957-2069c49
Version25.6
Bundle IDcom.jetpack.alpha
Commit2069c49
App Center Buildjetpack-installable-builds #10332
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Reader
Projects
None yet
Milestone
25.7
Development

Successfully merging this pull request may close these issues.
2 participants
@kean @wpmobilebot