[FLAG-997] GADM country list #4891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willian-viana
force-pushed
the
epic/gadm
branch
2 times, most recently
from
4d0b54d to
f6a9065
Compare
willian-viana
force-pushed
the
feat/GADM-country-list-FLAG-997
branch
3 times, most recently
from
dad9bf0 to
eb3e427
Compare
willian-viana
force-pushed
the
epic/gadm
branch
from
27728a3 to
9d96124
Compare
willian-viana
force-pushed
the
feat/GADM-country-list-FLAG-997
branch
from
eb3e427 to
2223e1c
Compare
name_0 to country and level to adm_level
make sure the adm_level is a number
willian-viana
force-pushed
the
feat/GADM-country-list-FLAG-997
branch
from
2223e1c to
6a8efa2
Compare
willian-viana
force-pushed
the
epic/gadm
branch
from
9d96124 to
d81eea8
Compare
willian-viana
commented
Dec 18, 2024
| const parsedResponse = []; | ||
| uniqBy(rows).forEach((row) => { | ||
| parsedResponse.push({ | ||
| id: parseGadm36Id(row.id).adm2, |
There was a problem hiding this comment.
Change the method name to cover 4.1 instead of 3.6
willian-viana
changed the title
willian-viana
force-pushed
the
epic/gadm
branch
from
d81eea8 to
4d705c8
Compare
Let the method more version agnostic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Brief description of what this PR does, and why it is needed.
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing