Features/hdev 345 unit tests mainnet #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update ci workflow, two tests - new hh fork config for tests - test commands for different networks - config importer util refactor - temporarily removed cadc and eurs tokens and assimilator tests - WIP: end to end tests for deposit, swap, withdraw
- Curve/Pair Contract
- updated mainnet BLOCK_NO to accomodate fxphp - erc20 contracts in setup - base assimilator object - refactor quote assimilator
- utils, minttagphp helper
- updated block no in config
Comment on lines
+17
to
+29
| if (process.env.NETWORK === 'mainnet') { | ||
| RPC_URL = `https://eth-mainnet.alchemyapi.io/v2/${ALCHEMY_PROJECT_ID}`; | ||
| BLOCK_NO = CONFIG.BLOCK_NO; | ||
| } else if (process.env.NETWORK === 'matic') { | ||
| RPC_URL = `https://polygon-mainnet.g.alchemy.com/v2/${ALCHEMY_PROJECT_ID}`; | ||
| BLOCK_NO = CONFIG.BLOCK_NO; | ||
| } else if (process.env.NETWORK === 'kovan') { | ||
| RPC_URL = `https://eth-kovan.alchemyapi.io/v2/${ALCHEMY_PROJECT_ID}`; | ||
| BLOCK_NO = CONFIG.BLOCK_NO; | ||
| } else { | ||
| RPC_URL = `https://eth-mainnet.alchemyapi.io/v2/${ALCHEMY_PROJECT_ID}`; | ||
| BLOCK_NO = CONFIG.BLOCK_NO; | ||
| } |
There was a problem hiding this comment.
Could we use a switch instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Unit tests for different network forks, mainnet, polygon and kovan
Link to Jira Ticket
Developer Checklist:
features/HDEV-XXX-descriptionReviewers Checklist: