Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added AvalancheProtocolFeesDistributor contract #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mystbrent
Copy link
Contributor

Description of Changes

  • Added AvalancheProtocolFeesDistributor.sol contract
  • Added AvalancheProtocolFeesDistributor unit test
  • Added Avax chain config in hardhat.config

Additional env:
AVAX_RPC_URL=
AVALANCHE_API_KEY=

https://start.1password.com/open/i?a=2VIA62LB7VAW3NACLOHTFW4ERI&h=halodao.1password.com&i=22nespt74nnvfru7rtctowgsxe&v=gllrg2so74fsgd43baj5q5voui

Link to Jira Ticket

How To Test

Developer Checklist:

  • I have followed the guidelines in our Contributing document
  • This PR has a corresponding JIRA ticket
  • My branch conforms with our naming convention i.e. feature/HDEV-XXX-description
  • I have written new tests for your core changes, as applicable
  • I have successfully ran tests locally
  • I have formatted my code using format document in VSCode

Reviewers Checklist:

  • Code is readable and understandable; any unclear parts have explanations
  • I have successfully ran tests locally

Copy link

@schystz schystz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and clean @mystbrent ! Also double checked the addresses and they appear to be correct.

Just some minor comments:

  • shall we remove .DS_Store (there are 2)?
  • not sure why there are changes on package-lock.json since there are no new deps installed

Copy link

@tracyarciaga tracyarciaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked and looks good.

@0xAplki 0xAplki self-requested a review July 14, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants