Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Cached Xcode to lowercase string #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerrymarino
Copy link

Currently, Apple yields a file of the name Xcode_VERSION.xip. When
loading this file from a cache, xcversion should be able to pick that
up.

It simply picks up the cached file by using a lowercase version of the
string.

Currently, Apple yields a file of the name Xcode_VERSION.xip. When
loading this file from a cache, xcversion should be able to pick that
up.

It simply picks up the cached file by using a lowercase version of the
string.
@supermarin
Copy link

@joshdholtz @KrauseFx whoever owns this, FASTLANE_PASSWORD needs to be updated:

Please provide your Apple Developer Program account credentials
The login information you enter will be stored in your macOS Keychain
You can also pass the password using the `FASTLANE_PASSWORD` environment variable
See more information about it on GitHub: https://github.com/fastlane/fastlane/tree/master/credentials_manager

@joshdholtz
Copy link
Member

@supermarin Thanks for noticing that! Hope all is well 😊

@milch Looks like you set that account up for the CI 🙃 Would you mind updating that whenever you are back at your computer working?

@milch
Copy link
Collaborator

milch commented Apr 18, 2020

The ENV vars are set up correctly, it looks like it's just what @Kesin11 mentioned in #383

We should probably just merge that PR so the E2E tests are disabled, as nice as having them would be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants