Fix #155 #157
Merged
Fix #155 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155. The bug was that we were unconditionally marking a field as "done" in our
TryJoinimplementations, and then branched on the output value, with only one branch writing a value.Our drop impl assumed that if a value was marked as "done" that the field was populated. But that wasn't true if
TryJoinreturned with an error, meaning it would attempt to drop uninitialized memory.This affects all three TryJoin implementations since they're subtle adaptations of one another. I believe this bug was introduced as part of the work towards #137. We should release a patch release as soon as we've merged this PR.