Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't specify the versionFile for tagpr #3036

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Don't specify the versionFile for tagpr #3036

merged 1 commit into from
Jan 2, 2025

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jan 1, 2025

It looks like we don't need to specify because the release versions should be synced with git tags.
https://github.com/Songmu/tagpr#tagprversionfile

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 1, 2025
@utam0k utam0k requested a review from a team January 1, 2025 12:37
YJDoc2
YJDoc2 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think we should also remove the .tagpr file from repo once we have verified this works in next release.

@utam0k
Copy link
Member Author

utam0k commented Jan 2, 2025

I think we should also remove the .tagpr file from repo once we have verified this works in next release.

No, we don't do that because .tagpr is the configure file for tagpr.

@utam0k utam0k merged commit 792f359 into youki-dev:main Jan 2, 2025
29 checks passed
This was referenced Jan 2, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YJDoc2 YJDoc2 YJDoc2 approved these changes

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utam0k @YJDoc2