Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
==========================================
+ Coverage 89.71% 89.74% +0.03%
==========================================
Files 27 27
Lines 914 917 +3
==========================================
+ Hits 820 823 +3
Misses 94 94
🚀 New features to boost your workflow:
|
Author
Author
|
Same note as on the sibling PRs: the red |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JenkinsLookup3.decodewrites the payload without.view("uint8")[:] = b[:-4], so an output buffer larger than the decoded payload silently broadcasts the single byte across the whole buffer:A buffer with the same byte count but another dtype/shape raises a broadcasting error, and a
bytearrayraisesAttributeError.This compares
memoryview(out).nbyteswith the payload before writing anything, and fills the buffer through a flatuint8view:The buffer is left untouched when the sizes differ, and a same-size
bytearrayor a multi-dimensional array now decodes as expected.Fixes #894.
Tests:
tests/test_jenkins.pygainstest_out_too_large_is_rejected,test_out_with_other_dtype_is_filledandtest_out_bytearray_is_filled.