FeaturePanel: Add a secondary label to prefer the users language #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is great. I have only one remark: Can you please fix the skeleton in useOnMapClicked: here to also include all Currently when you click a map feature, the skeleton is briefly displayed with different Headings and then the proper one is shown when Osm request loads. This causes unnecessary flicker on fast internet, or moving on slower one. More details here: https://github.com/zbycz/osmapp/wiki/ARCHITECTURE Performance is one of the most valued resources in OsmAPP and "loading skeleton" is a way to achieve this even though it makes it a little more difficult. |
|
Love it ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures the user sees everything that is relevant to them and more importantly that they can understand and read everything. Previously a English speaker might be confronted with Japanese kanji or another writing system they can't even read
Feel free to close this without merging if you don't like this :) It was just a quick idea
The secondary label only is shown when it differs from the main label as it is visible on the last screenshot.