Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement no_std support for zcash_transparent #1659

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

nuttycom
Copy link
Contributor

No description provided.

@nuttycom nuttycom changed the base branch from zcash_transparent_keys to zcash_transparent December 15, 2024 21:12
Base automatically changed from zcash_transparent to main December 15, 2024 21:30
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.98%. Comparing base (b1962ac) to head (b5b1225).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
zcash_transparent/src/pczt/tx_extractor.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1659      +/-   ##
==========================================
- Coverage   52.98%   52.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       21051    21051              
==========================================
- Hits        11154    11153       -1     
- Misses       9897     9898       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b5b1225

@str4d str4d merged commit efd8176 into main Dec 16, 2024
30 of 32 checks passed
@str4d str4d deleted the zcash_transparent_no_std branch December 16, 2024 07:27
@str4d
Copy link
Contributor

str4d commented Dec 16, 2024

Oops, I should have tested this with Keystone before merging; it's incomplete. I'll fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants