Deprecate reexports of types that have been moved to other crates. #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
=======================================
Coverage 52.25% 52.26%
=======================================
Files 179 179
Lines 21376 21362 -14
=======================================
- Hits 11171 11164 -7
+ Misses 10205 10198 -7 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
deprecate_reexports
branch
3 times, most recently
from
d97f306 to
0a9cfc7
Compare
…ates. This commit temporarily removes the reexported types to simplify the removal process; the reexports will be reintroduced with deprecation annotations in the subsequent commit.
nuttycom
force-pushed
the
deprecate_reexports
branch
from
0a9cfc7 to
684097a
Compare
nuttycom
commented
Dec 30, 2024
nuttycom
force-pushed
the
deprecate_reexports
branch
from
684097a to
4b712f7
Compare
Due to limitations described in rust-lang/rust#30827, we can't just deprecate the `pub use` stanzas; instead, we have to replace reexports with new (deprecated) modules and public types which then internally reexport the module internals or alias the reexported types, respectively.
nuttycom
force-pushed
the
deprecate_reexports
branch
from
4b712f7 to
4bdf39c
Compare
str4d
previously approved these changes
Dec 30, 2024
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack Grigg <[email protected]>
nuttycom
force-pushed
the
deprecate_reexports
branch
from
2e01292 to
1855385
Compare
str4d
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit of this PR removes the
pub usereexports of types that have been moved to other crates and replaces the internal usage of these types with the types from their new crates. The second commit reintroduces thosepub usereexports withdeprecatedpragmas.