Skip to content
CI checks

Refactor Sapling builder to separate out proof generation #3911

Sign in to view logs

Refactor Sapling builder to separate out proof generation

Refactor Sapling builder to separate out proof generation #3911

GitHub Actions / Clippy (MSRV) failed Oct 30, 2023 in 0s

Clippy (MSRV)

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.65.0 (897e37553 2022-11-02)
  • cargo 1.65.0 (4bc8f24d3 2022-10-20)
  • clippy 0.1.65 (897e375 2022-11-02)

Annotations

Check failure on line 853 in zcash_primitives/src/transaction/components/sapling/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

redundant closure 

error: redundant closure
   --> zcash_primitives/src/transaction/components/sapling/builder.rs:853:13
    |
853 |             |p| Ok(p),
    |             ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 852 in zcash_primitives/src/transaction/components/sapling/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

redundant closure 

error: redundant closure
   --> zcash_primitives/src/transaction/components/sapling/builder.rs:852:13
    |
852 |             |p| Ok(p),
    |             ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 750 in zcash_primitives/src/transaction/components/sapling/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

redundant closure 

error: redundant closure
   --> zcash_primitives/src/transaction/components/sapling/builder.rs:750:13
    |
750 |             |parts| MaybeSigned::SigningMetadata(parts),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `MaybeSigned::SigningMetadata`
    |
    = note: `-D clippy::redundant-closure` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 436 in zcash_primitives/src/transaction/components/sapling/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

very complex type used. Consider factoring parts into `type` definitions 

error: very complex type used. Consider factoring parts into `type` definitions
   --> zcash_primitives/src/transaction/components/sapling/builder.rs:436:10
    |
436 |     ) -> Result<Option<(Bundle<InProgress<Unproven, Unsigned>>, SaplingMetadata)>, Error> {
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D clippy::type-complexity` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
View more details on GitHub Actions