Provide AVOID_UB for some bugs found in GCC compiler testing #1785
+54
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fig02 <[email protected]>
hensldm
approved these changes
Jan 7, 2025
AngheloAlf
approved these changes
Jan 7, 2025
AngheloAlf
added
Merge-ready
fig02
reviewed
Jan 10, 2025
Comment on lines
+462
to
+467
| #ifdef AVOID_UB | ||
| //! @bug Z2_DEKU_KINGCutsceneData_008258 provides a cue id of 6, reading out-of-bounds | ||
| //! of this array that happens to be 0 padding. | ||
| // Avoid UB: Add an explicit array member rather than relying on 0 padding. | ||
| DEKU_KING_ANIM_IDLE, | ||
| #endif |
There was a problem hiding this comment.
should this mention mm3d and how it proves that it was infact an original bug?
There was a problem hiding this comment.
i would be interested to see how MM3D proves this to be padding, because it does currently match without the AVOID_UB tag
hensldm
added
the
Waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special thanks to @fig02 for the GCC playthrough that uncovered these, and for everyone else who looked into and discussed the problems.
The
z_message_nes.cAVOID_UB is particularly nasty.. suggestions welcome